sys/runtime_config: add runtime configuration#22092
Open
LasseRosenow wants to merge 126 commits into
Open
Conversation
LasseRosenow
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
github-actions
Bot
added
Area: doc
Teufelchen1
added
the
CI: ready for build
AnnsAnns
reviewed
Feb 24, 2026
Member
AnnsAnns
left a comment
AnnsAnns
left a comment
There was a problem hiding this comment.
It's fairly obvious that this has already went through multiple reviews in the past, it's really hard for me to find anything that isn't too nitpicky
Member
Author
|
Thank you for your review @AnnsAnns, I hope I should have addressed all your comments :) |
AnnsAnns
previously approved these changes
Feb 25, 2026
Member
AnnsAnns
left a comment
AnnsAnns
left a comment
There was a problem hiding this comment.
As said, this already went through quite a few reviews in the past, so there is nothing left blocking me here. However, I heard that @mguetschow wanted to also take a look at it so let's wait on them before merging this :)
crasbe
added
the
Type: new feature
Contributor
|
The CI is still kinda failing, so this can't be merged yet. |
LasseRosenow
force-pushed
the
pr-runtime-configuration-registry-core
branch
2 times, most recently
from
8952e1e to
5a0f76a
Compare
LasseRosenow
requested review from
MichelRottleuthner,
aabadie and
miri64
as code owners
LasseRosenow
force-pushed
the
pr-runtime-configuration-registry-core
branch
from
5a0f76a to
7e6b885
Compare
LasseRosenow
force-pushed
the
pr-runtime-configuration-registry-core
branch
2 times, most recently
from
67531e5 to
7241a0a
Compare
github-actions
Bot
added
Platform: native
Teufelchen1
reviewed
May 8, 2026
Teufelchen1
reviewed
May 8, 2026
Comment on lines
+195
to
+200
| successful = false; | ||
|
|
||
| const runtime_config_error_t res = runtime_config_apply(NULL); | ||
|
|
||
| TEST_ASSERT(successful); | ||
| TEST_ASSERT_EQUAL_INT(RUNTIME_CONFIG_ERROR_NONE, res); |
Contributor
There was a problem hiding this comment.
This won't catch if all are applied or only some.
Member
Author
There was a problem hiding this comment.
I now have a counter
Member
Author
There was a problem hiding this comment.
Well I guess I got confused. It seems to only be implemented in that traverse thing, I will add it here also then.
Teufelchen1
reviewed
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sys/runtime_config: add runtime configuration
Note
This is only the core (most minimal) implementation of the runtime configuration system.
This PR is split out of #19895 and see there for all features that will come in following PRs.
This is a continuation of the effort previously done in #10622, but its architecture has dramatically changed since then.
See doc.md for current documentation of this PR.